https://gitlab.synchro.net/main/sbbs/-/commit/7db3b623bd115c096f4a261d
Modified Files:
src/sbbs3/userdat.c userdat.h
Log Message:
Refactor putuserrec()

This started with a Coverity issue (CID 33230) which got me looking at this function and wondering: why is str2 being NUL-terminated here? Why is the length of str2 to be calculated on successive lines? What is with this (long)((long)((long)((long)) typecast?

This was some of the oldest code in Synchronet (along with a lot of the other functions in this file). I tried to keep as much intact as possible while still improving the logic and readability.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dd38606e246a2a4e2179d407
Modified Files:
src/sbbs3/userdat.c userdat.h
Log Message:
find_login_id() will now return 0 if login ID is an invalid user number

If login by number is supported and a client attempts login with an invalid usernumber, don't log an error, e.g.
mail 3264 SMTPS [46.148.x.x] !ERROR -2 getting data on user (6123)

But rather treat it as an invalid login attempt.

Also change lastuser() and total_users() to return int instead of uint. 2 billion users should be plenty.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/efdbc232d655709c4b3551dc
Modified Files:
src/sbbs3/userdat.c userdat.h
Log Message:
Add some helper functions for modifying node records in node.dab, atomically

These should probably be moved (along with other node functions in this file) to nodedat.* some day.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net